mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Srinivas Brahmaroutu <srbra...@us.ibm.com>
Subject Re: Review Request 51410: Enabled meta discovery using appc labels.
Date Mon, 19 Sep 2016 01:16:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51410/
-----------------------------------------------------------

(Updated Sept. 19, 2016, 1:16 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
    https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description
-------

Added appc_labels to mesos-execute so that we can indicate meta
discovery using useMetaDiscovery="true" along with other appc labels
that determines the os, arch of the image we are discovering. This logic
needs to be documented so that user can switch between simple and meta
discovery methods. This implementation is necessary as there is no other
way to determine from the URI.


Diffs (updated)
-----

  src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 
  src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp 907e761856e8996b72e4231de27fa15e884d52e3


Diff: https://reviews.apache.org/r/51410/diff/


Testing
-------

make check


Thanks,

Srinivas Brahmaroutu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message