mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 45962: Added a persistent volume test framework for shared volumes.
Date Sun, 18 Sep 2016 18:35:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45962/#review149370
-----------------------------------------------------------




src/Makefile.am (line 2270)
<https://reviews.apache.org/r/45962/#comment216949>

    Nit: Need use tab instead of spaces between `tests/persistent_shared_volume_framework_test.sh`
and ``



src/examples/persistent_shared_volume_framework.cpp (lines 207 - 209)
<https://reviews.apache.org/r/45962/#comment216972>

    Nit:
    ```
                      "COUNTER=0;"
                      "while [ $COUNTER -lt 5 ];"
                      "do"
                      "  echo " + task_id + ":Writing from main task=$COUNTER"
                      "  >> volume/persistent.dat;"
                      "  COUNTER=$[COUNTER+1];"
                      "  sleep 2;"
                      "done");
    ```



src/examples/persistent_shared_volume_framework.cpp (lines 249 - 251)
<https://reviews.apache.org/r/45962/#comment216971>

    Nits:
    
    ```
                      "COUNTER=0;"
                      "while [ $COUNTER -lt 5 ];"
                      "do"
                      "  tail -n 1 volume/persistent.dat;"
                      "  COUNTER=$[COUNTER+1];"
                      "  sleep 2;"
                      "done");
    ```



src/tests/examples_tests.cpp (lines 29 - 30)
<https://reviews.apache.org/r/45962/#comment216948>

    Nit: Need to add a extra blank line above.


- haosdent huang


On Sept. 15, 2016, 4:47 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45962/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 4:47 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4431
>     https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a persistent volume test framework for shared volumes.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am f1d202ae08d6bb4fd9e11eb1eae75dd9d5d9d8d5 
>   src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
>   src/tests/examples_tests.cpp 52fac33733cc86dd718c7836c5031999f1597a5c 
>   src/tests/persistent_shared_volume_framework_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45962/diff/
> 
> 
> Testing
> -------
> 
> New test framework for shared resources added.
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message