mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 45492: Used ChildHooks in Mesos [2/2].
Date Sat, 17 Sep 2016 14:09:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45492/#review149330
-----------------------------------------------------------


Ship it!




Ship It!

- Qian Zhang


On Sept. 12, 2016, 9:05 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45492/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 9:05 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jie Yu.
> 
> 
> Bugs: MESOS-5070
>     https://issues.apache.org/jira/browse/MESOS-5070
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We now use the new ChildHooks instead of explicit options such
> as setsid.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 16abf64f98cc833ea4bee28bc08951eb2ff6d995 
>   src/health-check/health_checker.cpp f373df19fc8af8e9650be61e3b101e89362a67cd 
>   src/launcher/posix/executor.cpp 7c40ebebb983b7977526fee123bf07c86fbb5e50 
>   src/linux/perf.cpp 556dc8dbb4170101ae9154afd4935df891db136f 
>   src/slave/container_loggers/lib_logrotate.cpp 1c170e5d11ef31d468b200c2c4cbd27abeeb418a

>   src/slave/containerizer/docker.cpp 110a1eb41b1ff7cb94f3630a1843d9f01efbe09c 
>   src/slave/containerizer/fetcher.cpp 4d3fc521bf8a7c438c48e31c549f108ac3602b3f 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp ed3aa1d4c7213acfde2f63ee719edab553c9bd79

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 822f11eab5b00c014563322a8c3b2c14cb440e0b

>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 55a06cfe1edbb7699c04101f78cc4979176e33f6

>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 5b9d5aaeb008e9b102e86736c9312db0b3266d34

>   src/slave/containerizer/mesos/launcher.cpp 8183a1cd511909e5680b793e1adbf8d26afa9ce5

>   src/slave/containerizer/mesos/linux_launcher.cpp d0f92856780f087908731ec0601692c78339d8a7

>   src/tests/containerizer/capabilities_tests.cpp 3ba46404c389385e02d2a1789e33dab3e8f15902

>   src/tests/containerizer/launch_tests.cpp 76d71b3088a7bec3b3f8546c197f65557f464028 
>   src/tests/containerizer/ns_tests.cpp e52ebbe93cd80236ca865a137de4251f25d55b05 
>   src/tests/containerizer/port_mapping_tests.cpp 7fac6ca1550acf54616fb4cef2eab1335f5e9760

> 
> Diff: https://reviews.apache.org/r/45492/diff/
> 
> 
> Testing
> -------
> 
> sudo Make check + internal ci
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message