mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 51966: Updated the 'gpu/nvidia' isolator to be nested container aware.
Date Fri, 16 Sep 2016 21:42:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51966/
-----------------------------------------------------------

(Updated Sept. 16, 2016, 9:42 p.m.)


Review request for mesos, Benjamin Mahler and Jie Yu.


Changes
-------

Updated to reintroduce the existence check for the cgroup in `recover()`.


Bugs: MESOS-6188
    https://issues.apache.org/jira/browse/MESOS-6188


Repository: mesos


Description (updated)
-------

In the process I also updated the Failure() / Log() messages in
'recover()' to contain more information (i.e. the same information as
the new generic cgroups isolator).


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 1383ba2dbb2be99b3eca0f2f62386438827e0bd6


Diff: https://reviews.apache.org/r/51966/diff/


Testing (updated)
-------

$ GTEST_FILTER="" make -j check
$ sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message