mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.
Date Thu, 15 Sep 2016 19:22:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51825/#review149116
-----------------------------------------------------------




src/common/type_utils.cpp (line 417)
<https://reviews.apache.org/r/51825/#comment216630>

    Can we use "." instead of "/" as the delimiter. Reason being that in `network/cni` isolator
we plan to use the stringified version of `ContainerID` to create directories for containers.
This would result in creating a hierarchy. Using "." instead of "/" would prevent it from
creating hierarchies. Also, recreating `ContainerID` from a flat hierarchy structure, would
much more cleaner.


- Avinash sridharan


On Sept. 12, 2016, 9:40 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51825/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 9:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, Kevin
Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-6073
>     https://issues.apache.org/jira/browse/MESOS-6073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the streaming function for ContainerID to be nesting aware.
> 
> 
> Diffs
> -----
> 
>   src/common/type_utils.cpp c7d50334b4e56bc0eb5473b9f9277465b607334f 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 96e24500a12825161553eb050da389088b122695

> 
> Diff: https://reviews.apache.org/r/51825/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message