mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 51913: Ignored agent registrations with duplicate agent IDs.
Date Thu, 15 Sep 2016 17:40:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51913/#review149083
-----------------------------------------------------------



Patch looks great!

Reviews applied: [50235, 50416, 50417, 50418, 50422, 50699, 50700, 50701, 50702, 50703, 50704,
50705, 50706, 50707, 50844, 50845, 50846, 51020, 51371, 51374, 51375, 51376, 51377, 51021,
51706, 51653, 51707, 51805, 51845, 51891, 51909, 51913]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Sept. 15, 2016, 1:40 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51913/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 1:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If an agent attempts to register and is assigned an agent ID that
> already appears in the registry, the likely cause is a UUID collision:
> slave IDs are prefixed with master IDs, and master IDs are randomly
> generated UUIDs. UUID collisions are extremely unlikely, so in practice
> this should never happen.
> 
> This commit updates the comments to clarify how unlikely this situation
> is. Furthermore, when it does happen, the master now just ignores the
> registration attempt, rather than trying to shutdown the agent. This is
> simpler; the agent will eventually try to register again and be assigned
> a new agent ID. Finally, it is unclear that shutting down the agent is
> actually appropriate: the previous coding added the duplicate ID to
> `slaves.removed`, which will interfere with the activity of the other
> slave whose ID we collided with.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 4992ab0a0bb5babbf6a4fa3e6eff3577590fc879 
>   src/master/master.cpp b88472f6350d3f71e057bab34822423da5427151 
> 
> Diff: https://reviews.apache.org/r/51913/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message