mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 51871: Modified the `isolate` method to be nesting aware.
Date Wed, 14 Sep 2016 16:25:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51871/
-----------------------------------------------------------

(Updated Sept. 14, 2016, 4:25 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Qian Zhang.


Changes
-------

Addressed Joseph's comemnts.


Summary (updated)
-----------------

Modified the `isolate` method to be nesting aware.


Bugs: MESOS-6156
    https://issues.apache.org/jira/browse/MESOS-6156


Repository: mesos


Description
-------

The network file setup in the `network/cni` isolator is now nesting
aware. Since the children share the network and UTS namespace with the
parent, the network files need to be created only for the parent
container. For the child containers, the network files will be simply
a symlink to a parents network files.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 822f11eab5b00c014563322a8c3b2c14cb440e0b


Diff: https://reviews.apache.org/r/51871/diff/


Testing
-------

make
make check
sudo ./bin/mesos-tests.sh


Thanks,

Avinash sridharan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message