mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Review Request 51850: Removed unneeded `Resources::add/remove(const Resource&)`.
Date Tue, 13 Sep 2016 17:04:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51850/
-----------------------------------------------------------

Review request for mesos, Anindya Sinha and Guangya Liu.


Repository: mesos


Description
-------

We can remove these given that they already call
`Resources::add/remove(const Resource_&)` internally and
a Resource is implicitly convertible to a Resource_.


Diffs
-----

  include/mesos/resources.hpp 87828aa5e4818efd40dd72dc199669281b8a15ae 
  include/mesos/v1/resources.hpp 27bdd275277edc60d97b720e596f21e8e8f8dc27 
  src/common/resources.cpp 77ee92193de1f34131f7a86b7d16731c9c3e17e2 
  src/v1/resources.cpp 4ba5bf87c9b9fef67eeb447a3f3b520f1e81ad77 

Diff: https://reviews.apache.org/r/51850/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message