mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 51148: Moved MockSlave into a separate header/implementation file.
Date Tue, 13 Sep 2016 14:34:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51148/#review148727
-----------------------------------------------------------



Patch looks great!

Reviews applied: [51149, 51150, 51151, 51808, 51152, 51148]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Sept. 13, 2016, 10:21 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51148/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2016, 10:21 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved MockSlave into a separate header/implementation file.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 2dd7913a1477f3c3560be4e2c1450b93fb3afc78 
>   src/tests/mesos.hpp 92d7d94733d461eb0c565830cc1c8e709e7a2ef7 
>   src/tests/mesos.cpp 539634eef8575a4e0091842343c29439f6d4d94c 
>   src/tests/mock_slave.hpp PRE-CREATION 
>   src/tests/mock_slave.cpp PRE-CREATION 
>   src/tests/oversubscription_tests.cpp 18da40e92a2717e9729c300799a4790bba379906 
>   src/tests/persistent_volume_tests.cpp d07ff1fd2f14c73c924a07ce3850bf0d9de2135a 
>   src/tests/reservation_tests.cpp 000957826011bf28f7550a83db3e60a796162fb3 
>   src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95 
> 
> Diff: https://reviews.apache.org/r/51148/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message