mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 45491: Refactored subprocess options [1/2].
Date Sun, 11 Sep 2016 20:17:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45491/
-----------------------------------------------------------

(Updated Sept. 11, 2016, 8:17 p.m.)


Review request for mesos, Alexander Rukletsov and Jie Yu.


Bugs: MESOS-5070
    https://issues.apache.org/jira/browse/MESOS-5070


Repository: mesos


Description
-------

Previously the subprocess interface supported a several options for the
child process such as setsid. In order to make the interface more
flexible we refactored such options into a vector of ChildHooks.
In order not to allow arbitrary code inside a ChildHook it has to be
constructed via pre-defined factory methods.


Diffs
-----

  3rdparty/libprocess/include/process/posix/subprocess.hpp 57f71d15e6fbb032c8b6c5d0c73a93751022e7e7

  3rdparty/libprocess/include/process/ssl/gtest.hpp 2ad623a5ea3b3286983e895010af756f14f51b64

  3rdparty/libprocess/include/process/subprocess_base.hpp acd23c99162f164c02a7781abeb95b3c220ead12

  3rdparty/libprocess/src/subprocess.cpp 8ca61f77083ac4b77aa1aec22806e1be43dbfa6c 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 0ff3945d2c722ebc1529265427397c5dfba6854e


Diff: https://reviews.apache.org/r/45491/diff/


Testing
-------

Tested entire chain see https://reviews.apache.org/r/45492.


Thanks,

Joerg Schad


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message