mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Janco <jjanco....@gmail.com>
Subject Re: Review Request 51028: Fix tests with rapidly triggered allocations.
Date Thu, 08 Sep 2016 22:06:39 GMT


> On Sept. 6, 2016, 9:59 a.m., Guangya Liu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 2594
> > <https://reviews.apache.org/r/51028/diff/2/?file=1476333#file1476333line2594>
> >
> >     Seems we should also `Clock::settle();` here, otherwise, this test may be failed
as r/51027
> 
> Jacob Janco wrote:
>     Since there is an `AWAIT_READY(allocation)` beforehand for the previous 2 calls to
the allocator, I believe we should be OK here.
> 
> Guangya Liu wrote:
>     Sorry, I posted this in the wrong place, it should be at https://reviews.apache.org/r/51027/
, after https://reviews.apache.org/r/51027/ , the `reviveOffer` will not allocate resource
directly but will be in a queue if no allocation pending.
>     
>     BTW: I suggest you chenge the order of this patch and https://reviews.apache.org/r/51027/
, it is better let this patch depend on https://reviews.apache.org/r/51027/ .
>     
>     You can run `./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.SuppressAndReviveOffers"
--gtest_repeat=20` after applied https://reviews.apache.org/r/51027/ and you will got some
error.

Missed this, yes this does cause flakiness in this test, caused by that dispatched allocate.


- Jacob


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/#review147809
-----------------------------------------------------------


On Aug. 23, 2016, 8:47 a.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51028/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2016, 8:47 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3157
>     https://issues.apache.org/jira/browse/MESOS-3157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Per MESOS-3157, if cluster events with the possibility
>   of triggering an allocation occur rapidly and test
>   assertions depend on gleaning information from assumed
>   order, it is likely they will fail due to lack of parity
>   between event and actual allocation. Settle the clock
>   between these events in tests sensitive to this to ensure
>   expected allocations occur.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp cbed333f497016fe2811f755028796012b41db77

> 
> Diff: https://reviews.apache.org/r/51028/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message