mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 51650: Removed dependency on external Docker image for mesos-tidy.
Date Thu, 08 Sep 2016 15:58:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51650/#review148196
-----------------------------------------------------------



Patch looks great!

Reviews applied: [51650]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Sept. 8, 2016, 11:57 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51650/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2016, 11:57 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order minimize external dependency modify the implementation of
> `support/mesos-tidy.sh` to build the mesos-tidy Docker container on
> the fly just before executing tests.
> 
> We follow the same basic idea already employed in
> `support/docker_build.sh` where the image is build, executed, and
> removed. Note that this approach likely does not take full advantage
> of Docker's caching capabilities.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy.sh 36e7f03ba2d9aa4ed982a82d8bbac3416dd52ad7 
> 
> Diff: https://reviews.apache.org/r/51650/diff/
> 
> 
> Testing
> -------
> 
> Confirmed that executing
> 
>     $ ./support/mesos-tidy.sh
>     
> give same results with external, or ad hoc container image.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message