mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.
Date Tue, 06 Sep 2016 22:38:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42861/#review147938
-----------------------------------------------------------



Thanks Haosdent! Looks good. Could you also add a test for this?


src/slave/slave.cpp (line 505)
<https://reviews.apache.org/r/42861/#comment215241>

    s/not/doesn't/


- Greg Mann


On April 1, 2016, 4:43 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42861/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 4:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and Neil Conway.
> 
> 
> Bugs: MESOS-4521
>     https://issues.apache.org/jira/browse/MESOS-4521
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ensure two Mount Disk resources do not have the same root path.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
> 
> Diff: https://reviews.apache.org/r/42861/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message