mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 50758: Updated `UserCgroupIsolatorTest` to use `CgroupsIsolatorProcess`.
Date Mon, 05 Sep 2016 19:23:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50758/#review147779
-----------------------------------------------------------




src/tests/containerizer/isolator_tests.cpp (lines 1600 - 1601)
<https://reviews.apache.org/r/50758/#comment215019>

    Hum, should we test all supported subsystems?



src/tests/containerizer/isolator_tests.cpp (lines 1623 - 1632)
<https://reviews.apache.org/r/50758/#comment215020>

    I don't like this way of launching a command. Let use master/agent/offer to launch a command
so that we don't have to update those tests when some internal interfaces change.
    
    I think we should take this opportunity to cleanup the tests.
    
    Can you move this test to cgroups_isolator_test.cpp?


- Jie Yu


On Sept. 5, 2016, 4:02 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50758/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2016, 4:02 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `UserCgroupIsolatorTest` to use `CgroupsIsolatorProcess`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/isolator_tests.cpp f8056ca08029feed5f164d4f94e24d521183bdfc

> 
> Diff: https://reviews.apache.org/r/50758/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message