mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 51324: Replaced use of `readdir_r` with `readdir`.
Date Mon, 05 Sep 2016 16:31:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51324/
-----------------------------------------------------------

(Updated Sept. 5, 2016, 4:31 p.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-6013
    https://issues.apache.org/jira/browse/MESOS-6013


Repository: mesos


Description
-------

`readdir_r` is deprecated in glibc >= 2.24 [1], which breaks the build.
In practice, modern implementations of `readdir` should be thread-safe
when concurrently invoked on different directory streams.

[1] https://sourceware.org/ml/libc-alpha/2016-02/msg00093.html


Diffs
-----

  3rdparty/stout/include/stout/internal/windows/dirent.hpp c6aa907f27350a8d9d4192d320cde3deb307d48b

  3rdparty/stout/include/stout/os/ls.hpp f8da9ef74a885cc39424b3e50cebca905d88ca44 

Diff: https://reviews.apache.org/r/51324/diff/


Testing (updated)
-------

make check on Linux with glibc>=2.24 and Mac OS X.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message