mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 51097: Added a `PortMapper` class.
Date Fri, 02 Sep 2016 23:46:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51097/#review147711
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp (line 36)
<https://reviews.apache.org/r/51097/#comment214925>

    Should put before `using std::cout`;



src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp (line 69)
<https://reviews.apache.org/r/51097/#comment214927>

    I think it would be better to define a `CNIError` exetends from `Error`, and return `Try<Owned<PorMapper>,
CNIError>` here?



src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.hpp (line
69)
<https://reviews.apache.org/r/51097/#comment214928>

    Should return `Try<Nothing>`, return `"OK"` looks a bit wried.



src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp (line
50)
<https://reviews.apache.org/r/51097/#comment214926>

    The indent should be 4 spaces.



src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp (line
187)
<https://reviews.apache.org/r/51097/#comment214930>

    Indent should be 4 spaces?


- haosdent huang


On Sept. 2, 2016, 10:33 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51097/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2016, 10:33 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-6023
>     https://issues.apache.org/jira/browse/MESOS-6023
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This class will embody the logic for implementing the CNI port-mapper
> plugin.
> 
> Also added helper functions in `cni::spec` to be able to log CNI
> plugin error as a JSON formatted string of `spec::error`.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 120a715eeeb7fb222d1169500950b5c7643df554 
>   src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp PRE-CREATION

>   src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.hpp
PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni/spec.hpp e6967415a689184f13d65a986f13b0af54364fb2

>   src/slave/containerizer/mesos/isolators/network/cni/spec.cpp 938a9f3bff2a95c8591450f0edafaddb01833e59

> 
> Diff: https://reviews.apache.org/r/51097/diff/
> 
> 
> Testing
> -------
> 
> Tested the port-mapper with the following CNI config:
> {
>     "name": "mynet",
>     "type": "port-mapper",
>     "chain": "MESOS",
>     "delegate": {
>       "type" : "bridge",
>       "bridge": "cni0",
>       "isGateway": true,
>       "ipMasq": true,
>       "ipam": {
>           "type": "host-local",
>           "subnet": "10.22.0.0/16",
>           "routes": [
>             { "dst": "0.0.0.0/0" }
>           ]
>       }
>     },
>     "args" : {
>       "org.apache.mesos" : {
>         "network_info" : {
>           "port_mappings": {
>             "host_port" : 80,
>             "container_port" : 80
>           }
>         }
>       }
>     }
> }
> 
> and the following environment variables:
> export CNI_COMMAND="ADD"
> export CNI_CONTAINERID="0000000111101110"
> export CNI_PATH="$MESOS_INSTALL:/home/vagrant/dev/go/cni/bin"
> export CNI_IFNAME="eth0"
> export CNI_NETNS="/etc/netns"
> 
> If we remove fields from the above CNI config, or remove certain environment variables
the creation of the `PortMapper` correctly fails. However, if config and environment variables
are passed as is it will create the `PortMapper` correctly.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message