mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51061: Added LAUNCH_GROUP offer operation.
Date Sun, 14 Aug 2016 04:25:03 GMT
Thanks James, one question here: so what is the use case of non-shared
volumes for specific tasks, can you please show some detail here? From
Kubernetes Pod/Storage, I can see that all of the volumes are shared
objects, and different containers can select the volume that they want to
mount. One example is here:
https://github.com/kubernetes/kubernetes/blob/master/examples/volumes/iscsi/iscsi.yaml

Thanks,

Guangya

On Sun, Aug 14, 2016 at 7:09 AM, James DeFelice <james.defelice@gmail.com>
wrote:

> I'll let Jie comment on exactly how things get filled in. The use cases
> are: (a) shared volumes among a taskgroups's tasks; (b) non-shared
> (private) volumes for specific tasks in a taskgroup
>
> On Sat, Aug 13, 2016 at 7:07 PM, Guangya Liu <gyliu513@gmail.com> wrote:
>
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/51061/
>>
>> On 八月 13th, 2016, 10:18 p.m. UTC, *Guangya Liu* wrote:
>>
>> include/mesos/mesos.proto
>> <https://reviews.apache.org/r/51061/diff/1/?file=1472355#file1472355line1379>
(Diff
>> revision 1)
>>
>> 1379
>>
>>  * 2) `NetworkInfo` must not be set inside task's resources.
>>
>> As we want to allow containers share a network namespace and volumes, so I think
that we shoud also highlight Volume here.
>>
>> Another point is I think here you mean
>>
>> 2) `NetworkInfo` must not be set inside task's `ContainerInfo`.
>>
>> As the TaskInfo has a resources field, so using ContainerInfo or
>> container for above may be more clear?
>>
>> For the above, what about add a new item for Volume as following:
>>
>> 3) `Volume` can be set in both executor level and task level so as to share a volume
between executor and task.
>>
>>
>> - Guangya
>>
>> On 八月 12th, 2016, 11:12 p.m. UTC, Vinod Kone wrote:
>> Review request for mesos, Anand Mazumdar, Benjamin Hindman, Benjamin
>> Mahler, James DeFelice, and Jie Yu.
>> By Vinod Kone.
>>
>> *Updated 八月 12, 2016, 11:12 p.m.*
>> *Bugs: * MESOS-6036 <https://issues.apache.org/jira/browse/MESOS-6036>
>> *Repository: * mesos
>> Description
>>
>> A scheduler can use the LAUNCH_GROUP offer operation to send a
>> `TaskGroup` to an executor.
>>
>> Testing
>>
>> make check
>>
>> Diffs
>>
>>    - include/mesos/mesos.proto (af29dab2af4c28e257ad518c68d3f1af7cad0d06)
>>    - include/mesos/v1/mesos.proto (a836f6e792944726ec6f8f66f77f4
>>    03894377d05)
>>    - src/common/resources.cpp (6b7af9179121efbdc5c29484eb042778bcea8288)
>>    - src/master/master.cpp (0bd1a3490a86fede86a3f5f62ce4745b65aae258)
>>    - src/v1/resources.cpp (03ee0cb0bb5abe7fc1ae4cb47c5b6dbcd8d11998)
>>
>> View Diff <https://reviews.apache.org/r/51061/diff/>
>>
>
>
>
> --
> James DeFelice
> 585.241.9488 (voice)
> 650.649.6071 (fax)
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message