mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.
Date Mon, 29 Aug 2016 17:02:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51052/#review147144
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/docker/docker.cpp (line 526)
<https://reviews.apache.org/r/51052/#comment214252>

    I suggest to add an extra line above.



src/docker/docker.cpp (line 528)
<https://reviews.apache.org/r/51052/#comment214248>

    An extra line below to match mesos style.



src/docker/docker.cpp (line 530)
<https://reviews.apache.org/r/51052/#comment214249>

    Should be 
    ```
    argv.push_back(stringify(static_cast<uint64_t>(quota.us())));
    ```
    here?



src/docker/executor.hpp (lines 91 - 96)
<https://reviews.apache.org/r/51052/#comment214250>

    Should we put `bool cgroups_enable_cfs;` after `task_environment`?
    
    For example:
    
    ```
    Option<std::string> task_environment;
    bool cgroups_enable_cfs;
    
    // TOD.
    ```


- haosdent huang


On Aug. 24, 2016, 8:32 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51052/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2016, 8:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-2154
>     https://issues.apache.org/jira/browse/MESOS-2154
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fixes cpu quota for command executor (which runs outside
> of the docker container) by ensuing --cpu-quota flag to docker
> run.
> 
> Note: we have to add the boolean variable to `Docker` class
> because `Docker::run()` has reached the maximum argument length
> GMOCK can support.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
>   src/docker/docker.cpp e07c4aa723f57db7f8bc31d4af5d32a30ebf98f2 
>   src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
>   src/docker/executor.cpp 8d679cd33b6ddf3a5c11bb8c458a97b8809473ac 
>   src/slave/containerizer/docker.cpp e447c58bd46ba080529e8f349347eccf5a54110a 
>   src/tests/mesos.cpp f5034f9f8de7040182e10f51be125a87b29fdd24 
> 
> Diff: https://reviews.apache.org/r/51052/diff/
> 
> 
> Testing
> -------
> 
> I am now able to make docker containers launched through mesos-execute have a cpu quota.
> 
> Also making sure `make check` still works on mac os for the linux only flag.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message