mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51096: Added the `mesos-port-mapper` binary.
Date Fri, 26 Aug 2016 19:10:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51096/#review147004
-----------------------------------------------------------




src/Makefile.am (line 1345)
<https://reviews.apache.org/r/51096/#comment213950>

    mesos-cni-port-mapper?
    
    Port mapper sounds too general to me.



src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp (line 26)
<https://reviews.apache.org/r/51096/#comment213951>

    Please include `spec.hpp` rather than the protobuf header directly.



src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp (line 35)
<https://reviews.apache.org/r/51096/#comment213952>

    kill this line.



src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp (line 38)
<https://reviews.apache.org/r/51096/#comment213953>

    2 lines apart.



src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp (lines 43
- 46)
<https://reviews.apache.org/r/51096/#comment213956>

    Any reason you want to initialize the error here, instead of below where you set the error
message?



src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp (line 48)
<https://reviews.apache.org/r/51096/#comment213955>

    We should introduce a stout read function to read an fd till EOF (similar to read(path)).
Can you add a TODO here?


- Jie Yu


On Aug. 26, 2016, 12:29 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51096/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2016, 12:29 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-6023
>     https://issues.apache.org/jira/browse/MESOS-6023
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `mesos-port-mapper` is a CNI plugin that can be used to install
> port-forwarding rules for a container. The `mesos-port-mapper` is a
> wrapper CNI plugin that should always be used in conjunction with
> other CNI plugins.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 120a715eeeb7fb222d1169500950b5c7643df554 
>   src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/51096/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message