mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.
Date Thu, 25 Aug 2016 19:17:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50947/#review146831
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (lines 146 - 149)
<https://reviews.apache.org/r/50947/#comment213554>

    This comment is confusing. I'd probably just leave it as it was, but say that this is
only required for the mesos containerizer, i.e.:
    
    `` Don't allow the `--nvidia_gpu_devices` flag without the GPU isolator when using the
mesos containerizer. For the docker containerizers, this is not required.```


- Kevin Klues


On Aug. 15, 2016, 7:29 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50947/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2016, 7:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5975
>     https://issues.apache.org/jira/browse/MESOS-5975
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while
> docker and external containerizers do not need it anymore. This removed
> the 'gpu/nvidia' isolator check for docker and external containerizers.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/gpu/allocator.cpp c1a87e9e5c07529bc1d077f68477108a40506806

> 
> Diff: https://reviews.apache.org/r/50947/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message