mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51409: Printed all the isolator cleanup errors during destory.
Date Thu, 25 Aug 2016 18:26:21 GMT


> On Aug. 25, 2016, 8:22 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 1768-1769
> > <https://reviews.apache.org/r/51409/diff/1/?file=1485400#file1485400line1768>
> >
> >     We should still keep the `ContainerID`, right?

Nope, caller will (and should) print the container Id.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51409/#review146760
-----------------------------------------------------------


On Aug. 25, 2016, 5:22 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51409/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2016, 5:22 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The current code only prints the first error.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 8a8985a6627859365c4f87ea0cbb5f89190cd4b3

> 
> Diff: https://reviews.apache.org/r/51409/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message