mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 51325: Removed unused function `os::dirent_size`.
Date Wed, 24 Aug 2016 01:31:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51325/#review146601
-----------------------------------------------------------



Patch looks great!

Reviews applied: [51324, 51325]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Aug. 23, 2016, 9:41 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51325/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2016, 9:41 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-6013
>     https://issues.apache.org/jira/browse/MESOS-6013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unused function `os::dirent_size`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/Makefile.am 1f2ee85846342b3f5d1c4f8dafda6c763f6ecdfa 
>   3rdparty/stout/include/stout/os/direntsize.hpp 819f99a89862491e99873bdedc603317b91266b0

>   3rdparty/stout/include/stout/os/posix/direntsize.hpp 9d8f72eb607a288e77f92b39b91542ff5eb2fa21

>   3rdparty/stout/include/stout/os/windows/direntsize.hpp 7c8c7a06f478b3a80341a874494cff21f71fc397

> 
> Diff: https://reviews.apache.org/r/51325/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message