mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 49851: Implemented `MemorySubsystem`.
Date Mon, 22 Aug 2016 13:22:02 GMT


> On Aug. 22, 2016, 3:04 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 553-559
> > <https://reviews.apache.org/r/49851/diff/21/?file=1480165#file1480165line553>
> >
> >     I think these codes can be merged into a single line `infos[containerId]->limiation.set(future);`
which will internally handle all the cases (ready, failed, discarded).

+1


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49851/#review146283
-----------------------------------------------------------


On Aug. 21, 2016, 9:29 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49851/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2016, 9:29 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5045
>     https://issues.apache.org/jira/browse/MESOS-5045
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented `MemorySubsystem`.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ff51705202569b85922d877ef95750d7943372d8 
>   src/Makefile.am 61c941f42bdccdf1745f72f875cb5c5a9901dc76 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 9b2d33ec3b023058d00c6671464cc9cd092f653b

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 0c724523a8b46f74a52214ae2b223f41f8dc2d58

>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 4a7b556bb74cfda0a74e1b9b5d4bb226b84751c1

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 06f4400966ba467623556901b38d12e69fbbbd04

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp df701d2fa7ce7622e6a32904ba3a99fd36b02df6

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp PRE-CREATION

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/49851/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message