mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 51053: Update leveldb to 1.19.
Date Mon, 22 Aug 2016 07:22:33 GMT


> On Aug. 22, 2016, 2:29 a.m., Vinod Kone wrote:
> > Have you also done compatibility tests mentioned in the ticket?

No. It's minior upgrade from 1.18 to 1.19 but I can got thur https://docs.google.com/document/d/1fv2OMvH6hVm6waacOejSrTJwUuDQeXlqqPDZjBmbcKU/edit#
and check if everything is OK.


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51053/#review146280
-----------------------------------------------------------


On Aug. 12, 2016, 11:17 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51053/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2016, 11:17 p.m.)
> 
> 
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent huang, and
Vinod Kone.
> 
> 
> Bugs: MESOS-970
>     https://issues.apache.org/jira/browse/MESOS-970
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Leveldb in modern version is required to support s390x and arm64.
> It's also required to replace default byte-wise comparator
> with varint comparator in `src/log/leveldb.cpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 662146fade019e3085c00242dd74215ee91d6a70 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake eeb27860f6f95d297ccfe273ed76de5355b50ff8

>   3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe 
>   3rdparty/leveldb-1.19.patch PRE-CREATION 
>   3rdparty/leveldb-1.19.tar.gz PRE-CREATION 
>   3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
>   3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
>   3rdparty/versions.am 08e47b6c93be51b0ea86f099f76e9d2a4a6ffd78 
>   LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/python/native_common/ext_modules.py.in 2d4a45efa224b32f80ace4542a00062c5ccb06d5

> 
> Diff: https://reviews.apache.org/r/51053/diff/
> 
> 
> Testing
> -------
> 
> make -j 8 distcheck
> benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message