mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.
Date Fri, 19 Aug 2016 02:19:36 GMT


> On Aug. 17, 2016, 4:06 p.m., Qian Zhang wrote:
> > src/tests/environment.cpp, line 438
> > <https://reviews.apache.org/r/50750/diff/7/?file=1475603#file1475603line438>
> >
> >     Here can we change it to the following?
> >     ```
> >     if (matches(test, "ROOT_CGROUPS_Isolate") ||
> >         matches(test, "ROOT_CGROUPS_ContainerStatus") {
> >     ```
> >     In this way, I think you can still name the test class as `CgroupsIsolatorTest`
which will be consistent with other cgroup's related tests.
> 
> haosdent huang wrote:
>     I found `ROOT_CGROUPS_Isolate` and `ROOT_CGROUPS_ContainerStatus` are not exactly
enough here because it only test net_cls. Should we use `ROOT_CGROUPS_NetSubsystemIsolate`
and `ROOT_CGROUPS_NetSubsystemContainerStatus` respectively.
> 
> Qian Zhang wrote:
>     I think they should be `ROOT_CGROUPS_NetClsIsolate` (rather than `ROOT_CGROUPS_Isolate`)
and `ROOT_CGROUPS_ContainerStatus` which are the original test names. So can you please let
me know if `ROOT_CGROUPS_NetClsIsolate` and `ROOT_CGROUPS_ContainerStatus` are enough? I think
it should be OK since we are doing the similar thing in `PerfCPUCyclesFilter::disable()`,
right?
> 
> haosdent huang wrote:
>     `CgroupsIsolatorTest.ROOT_CGROUPS_ContainerStatus` sounds not exactly, how about
`CgroupsIsolatorTest.ROOT_CGROUPS_ContainerNetClsStatus`?

What about name it as `ROOT_CGROUPS_NetClsContainerStatus` which seems more consistent with
`ROOT_CGROUPS_NetClsIsolate`?


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/#review145965
-----------------------------------------------------------


On Aug. 19, 2016, 12:10 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50750/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5976
>     https://issues.apache.org/jira/browse/MESOS-5976
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed CgroupsNetClsIsolatorProcess.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/slave/containerizer/mesos/containerizer.cpp 77a502f853e3e04ea8e274419544601778be9421

>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b3fd8c85476bf46368bd79f052b7923ad9d32199

>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp bebefbba7153d4b0e9a8d7179cfb642e6e802bea

>   src/tests/containerizer/isolator_tests.cpp 05620d2411d464593cdb5aeaea10cb147047569b

>   src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 
> 
> Diff: https://reviews.apache.org/r/50750/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message