mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51160: Use http instead of https for localhost registry on non 443 port.
Date Wed, 17 Aug 2016 23:26:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51160/#review146052
-----------------------------------------------------------


Fix it, then Ship it!





src/docker/spec.cpp (lines 129 - 136)
<https://reviews.apache.org/r/51160/#comment212417>

    I'd do the following:
    ```
    if (port.get() == 443) {
      return "https";
    }
    
    if (port.get() == 80) {
      return "http";
    }
    
    // NOTE: For a local registry, it's typically a http server.
    const string host = getRegistryHost(registry);
    if (host == "localhost" || host == "127.0.0.1") {
      return "http";
    }
    ```


- Jie Yu


On Aug. 17, 2016, 12:42 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51160/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2016, 12:42 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6005
>     https://issues.apache.org/jira/browse/MESOS-6005
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use http instead of https for localhost registry on non 443 port.
> 
> 
> Diffs
> -----
> 
>   src/docker/spec.cpp 2711578626dd1847f73cbf7bd3771f36e6755a99 
>   src/tests/containerizer/docker_spec_tests.cpp 1c6473aa9b9c2e56d32d10dc88d9bc66f563d91e

> 
> Diff: https://reviews.apache.org/r/51160/diff/
> 
> 
> Testing
> -------
> 
> Tested that Mesos agent is able to pull images from registry at 127.0.0.1:<non-443-port>.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message