mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 51122: Fixed memory leak in agent signal handlers.
Date Tue, 16 Aug 2016 19:51:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51122/
-----------------------------------------------------------

(Updated Aug. 16, 2016, 12:51 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, Artem Harutyunyan, and Vinod Kone.


Changes
-------

Update comment!


Repository: mesos


Description
-------

This leak was introduced on purpose in:
https://reviews.apache.org/r/34016/

When we run tests in repetition, each agent will create a new signal
handler and leak the old one.  This patch frees the old signal handler
and fixes up some related comments, because the behavior of calling the 
signal handler helper multiple times is predicable.

Also fixes a related typo.


Diffs (updated)
-----

  src/slave/posix_signalhandler.hpp 4a5411793e55f912c6e8ae72f9a8042d3a6195b5 
  src/slave/slave.cpp 0feb5c5b6498fe2627a9239b2c1aea78f1c57e49 
  src/slave/windows_ctrlhandler.hpp 9481e0f6271031d13ac6d1759372d466f52f8de5 

Diff: https://reviews.apache.org/r/51122/diff/


Testing
-------

Found this leak via code inspection after valgrind.

make check (OSX)

bin/mesos-agent.sh --work_dir=/tmp/agent --master=localhost:5050
kill -SIGUSR1 <agent pid>
Saw the appropriate line in the log: `slave.cpp:800] Received SIGUSR1 signal from user <me>;
shutting down

bin/mesos-tests.sh --gtest_filter="*SIGUSR1*" --gtest_repeat=100


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message