mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lawrence Wu <lawren...@twitter.com>
Subject Re: Review Request 50540: Add systemd watchdog support.
Date Fri, 12 Aug 2016 20:18:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50540/
-----------------------------------------------------------

(Updated Aug. 12, 2016, 8:18 p.m.)


Review request for mesos, David Robinson and Ian Downes.


Changes
-------

address feedback


Bugs: MESOS-5376
    https://issues.apache.org/jira/browse/MESOS-5376


Repository: mesos


Description
-------

Add systemd watchdog support.


Diffs (updated)
-----

  configure.ac d2136909b7305498ae901a5ea00133142b77f9e6 
  src/Makefile.am 599ebbef6d164fb2a530b55427ddabb5cd607634 
  src/linux/systemd.hpp 91134f1d4b100759e45931bd09ca4e1e1aeaaf8a 
  src/linux/systemd.cpp 619aa2778da5f99d3a078a8e1208bdaa9dc77581 
  src/slave/main.cpp 4624392d30cf391015dcd63f447fe2414a47a16a 
  src/tests/linux/systemd_test_helper.hpp PRE-CREATION 
  src/tests/linux/systemd_test_helper.cpp PRE-CREATION 
  src/tests/linux/systemd_test_helper_main.cpp PRE-CREATION 
  src/tests/linux/systemd_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50540/diff/


Testing
-------

Tested by sending SIGSTOP to running mesos and verifying via journalctl that it was killed
by the watchdog.

The test I wrote for this does the following:
- build up a unit file as a string and create a unit file in /etc/systemd/system/systemd-test-helper.service
- reload the systemd daemon and start the newly discovered helper service
- wait a bit (30s) to make sure the watchdog has had a chance to kill the service
- use systemctl status systemd-test-helper to check that the service is still running
- clean up the unit file.

TODO: create a similar test, but send a SIGSTOP to the service and ensure that it has been
killed by watchdog.


Thanks,

Lawrence Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message