mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 50992: Make MESOS_{MAJOR|MINOR|PATCH}_VERSION macros integer in header.
Date Thu, 11 Aug 2016 17:12:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50992/#review145522
-----------------------------------------------------------



As mentioned on chat, I think this will break some external module builds. I'm fine with that,
just pointing it out for posterity.

I noticed that the Java bindings use these in the MesosNativeLibrary.Version class. The Java
side of the bindings says this is a ``jlong``, but prior to this change it would have been
a string AFAICT. So I guess this fixes that too?

- James Peach


On Aug. 11, 2016, 5 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50992/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2016, 5 p.m.)
> 
> 
> Review request for mesos, Xiaojian Huang, haosdent huang, James Peach, Joris Van Remoortere,
Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4638
>     https://issues.apache.org/jira/browse/MESOS-4638
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This makes version based conditional compiling much easier for
> module writers.
> 
> 
> Diffs
> -----
> 
>   include/mesos/version.hpp.in c8fbc822d91abb61df15715c0c6af98b0bfe2cb9 
> 
> Diff: https://reviews.apache.org/r/50992/diff/
> 
> 
> Testing
> -------
> 
> make on Mac OS and Linux.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message