mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 49707: Replaced raw string with const.
Date Thu, 11 Aug 2016 06:32:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49707/#review145470
-----------------------------------------------------------


Ship it!





src/slave/containerizer/fetcher.cpp (lines 199 - 200)
<https://reviews.apache.org/r/49707/#comment211715>

    Formatting:
    
    ```
      if (!strings::startsWith(uri, FILE_URI_PREFIX) &&
          strings::contains(uri, "://")) {
    ```


- Michael Park


On July 6, 2016, 3:33 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49707/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 3:33 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced raw string with const.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/fetcher.cpp 8545d9813058e3f7af93ebadccec64a355333b72 
> 
> Diff: https://reviews.apache.org/r/49707/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message