mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 50851: Decode Protobuf long int form strings.
Date Wed, 10 Aug 2016 23:53:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50851/#review145430
-----------------------------------------------------------



Can you add the reason/motivation for this change in your patch description?


3rdparty/stout/include/stout/protobuf.hpp (lines 443 - 459)
<https://reviews.apache.org/r/50851/#comment211658>

    I wonder how far we want to follow the protobuf mapping recommendations.  Technically,
protobuf3 takes strings for all types of numbers :)
    
    I'm fine with just large numbers however.



3rdparty/stout/include/stout/protobuf.hpp (line 447)
<https://reviews.apache.org/r/50851/#comment211662>

    Unfortunately, `std::stoll` and similar functions will throw exceptions if they fail.
 And Mesos does not use exceptions.
    
    You'll need to parse the string some other way (i.e. `strtoimax`) and return an `Error`
if the parsing fails.



3rdparty/stout/tests/protobuf_tests.cpp (lines 334 - 336)
<https://reviews.apache.org/r/50851/#comment211656>

    This should be checking for equality, rather than parse success:
    
    EXPECT_SOME_EQ(<some JSON object>, json);



3rdparty/stout/tests/protobuf_tests.cpp (lines 342 - 343)
<https://reviews.apache.org/r/50851/#comment211657>

    This is actually a Protobuf -> JSON -> String conversion.
    
    You'll want to split these two apart and have one comparision for each step.


- Joseph Wu


On Aug. 5, 2016, 7:33 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50851/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2016, 7:33 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Joseph Wu.
> 
> 
> Bugs: MESOS-5995
>     https://issues.apache.org/jira/browse/MESOS-5995
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Decode Protobuf long int form strings.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/protobuf.hpp 91305e104c01d649bd435a27b159540222236c27

>   3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f 
> 
> Diff: https://reviews.apache.org/r/50851/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message