mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 50964: Windows: Fix build in src/launcher/executor.*.
Date Wed, 10 Aug 2016 20:08:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50964/
-----------------------------------------------------------

(Updated Aug. 10, 2016, 1:08 p.m.)


Review request for mesos, Anand Mazumdar and Artem Harutyunyan.


Changes
-------

Finished debugging build on Windows.  Needed to add some more headers.


Repository: mesos


Description
-------

The namespace was refactored in some other cleanup:
https://reviews.apache.org/r/50411/


Diffs (updated)
-----

  src/launcher/windows/executor.hpp bae44f5188e2ca46a744a033eb3d00998b3192d6 
  src/launcher/windows/executor.cpp a7b8125e67ad6cd825fad11fd9788255c4922843 

Diff: https://reviews.apache.org/r/50964/diff/


Testing
-------

Equivalent of `make` on Windows 10.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message