mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.
Date Tue, 09 Aug 2016 01:07:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40413/
-----------------------------------------------------------

(Updated Aug. 8, 2016, 6:07 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.


Changes
-------

Rebased on the Process ID change by Gaston.


Bugs: MESOS-3934
    https://issues.apache.org/jira/browse/MESOS-3934


Repository: mesos


Description
-------

The reaper singleton must be unified with `process::initialize` so 
that it also falls under the scope of reinitialization.  The singleton 
must also not be guarded by `Once`.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/reap.hpp 1a9709c618c5ddc9d2b7492cc1855a11f1fc4fb9 
  3rdparty/libprocess/src/process.cpp 629f1644bc0a263972ec9efc41890c33f9406a34 
  3rdparty/libprocess/src/reap.cpp f8d2fdc3449744cfd6a974170484b676e8f3ac7b 

Diff: https://reviews.apache.org/r/40413/diff/


Testing
-------

Tests done in a subsequent review.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message