mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 50563: Made HierarchicalAllocatorProcess specify a process ID.
Date Wed, 03 Aug 2016 12:55:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50563/#review144611
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Aug. 2, 2016, 1:55 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50563/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 1:55 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5917
>     https://issues.apache.org/jira/browse/MESOS-5917
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> I had to move the initialization of ProcessBase to the public
> HierarchicalAllocatorProcess constructor. The ID would otherwise get
> lost, leading to an undistinguishable ID.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp b72ba16277a3210e4d309b616d185a10e2029a66

> 
> Diff: https://reviews.apache.org/r/50563/diff/
> 
> 
> Testing
> -------
> 
> `make check` in OS X and various linux distributions, checked the output of `__processes__`.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message