mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 49924: Added libprocess as a shared library.
Date Wed, 03 Aug 2016 06:15:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49924/#review144586
-----------------------------------------------------------



Bad patch!

Reviews applied: [49924, 49921, 49874, 49870, 49863, 49862, 49688]

Failed command: ./support/apply-review.sh -n -r 49863

Error:
2016-08-03 06:14:57 URL:https://reviews.apache.org/r/49863/diff/raw/ [12706/12706] -> "49863.patch"
[1]
error: patch failed: src/CMakeLists.txt:501
error: src/CMakeLists.txt: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14610/console

- Mesos ReviewBot


On Aug. 2, 2016, 9:41 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49924/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 9:41 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added libprocess as a shared library.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/CMakeLists.txt d1547ef6a8762385f653d3824307727e4d0a7e71 
> 
> Diff: https://reviews.apache.org/r/49924/diff/
> 
> 
> Testing
> -------
> 
> cmake .. && make
> 
> With this patch and https://reviews.apache.org/r/49862,  Converted libmesos, http_parser
and libprocess to shared libraries and we are using libevent shared library, zookeeper does
not have a shared library in the 3rdparty (I guess the code is compiled as relocatable) and
did not have issues linking.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message