mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 50516: Fixed quoting for executor IDs in log messages.
Date Tue, 02 Aug 2016 16:34:44 GMT


> On July 29, 2016, 7:05 p.m., Anand Mazumdar wrote:
> > hmm, why can't the TaskID's have spaces? 
> > 
> > They are generated by the framework and are free to contain spaces.
> 
> Neil Conway wrote:
>     Yeah, I was wondering that myself :) We don't quote them almost all the time, however.
I figured I would first make it consistent and then do a sweep to fix the quotation later
-- but I can do that now if you'd prefer.
> 
> Anand Mazumdar wrote:
>     Yeah, would be good to fix them all now since we are at it.
> 
> Neil Conway wrote:
>     I don't have time to do task IDs at the moment, so I just removed this change.

np, mind filing a newbie JIRA issue to track this for posterity?


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50516/#review144155
-----------------------------------------------------------


On Aug. 2, 2016, 3:58 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50516/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2016, 3:58 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Executor IDs should be quoted.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp f8343768f3dc803e6bd7f4253c77d9fef82408e5 
>   src/slave/slave.cpp c19a63e4f8df11d8150071ef427bd8038584586b 
> 
> Diff: https://reviews.apache.org/r/50516/diff/
> 
> 
> Testing
> -------
> 
> make check, visual inspection.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message