mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 50609: Moved check for '--version' in agent's 'main.cpp'.
Date Tue, 02 Aug 2016 16:14:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50609/
-----------------------------------------------------------

(Updated Aug. 2, 2016, 4:14 p.m.)


Review request for mesos, Jie Yu and Pierre Cheynier.


Changes
-------

Addressed comment.


Bugs: MESOS-5928
    https://issues.apache.org/jira/browse/MESOS-5928


Repository: mesos


Description
-------

The recent removal of the agent's default `work_dir`
requires us to check for the presence of the `--version`
flag before we check for errors in flag loading; this
patch makes that change.


Diffs (updated)
-----

  src/master/main.cpp e202973e92ee065b93c0b431cae0bc066cbd7dc7 
  src/slave/main.cpp a4d971a00f18af661a8bf2cb4f580d35f7c76d10 

Diff: https://reviews.apache.org/r/50609/diff/


Testing
-------

Ran the mesos agent binary with and without the '--version' flag to verify correct behavior
and return code.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message