mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 50664: Fixed continuation logic in logrotate module.
Date Mon, 01 Aug 2016 18:16:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50664/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Repository: mesos


Description
-------

Previously the module's inner loop followed via `.then([=]`
which potentially executes the continuation on a different process.
This patch fixes this behavior (it should run on the same process)
and future-proofs this code in case the module is extended with
additional processes/behavior.


Diffs
-----

  src/slave/container_loggers/logrotate.cpp b863d931b08992ea9e94a7e6837b44cfc94ae8f1 

Diff: https://reviews.apache.org/r/50664/diff/


Testing
-------

make check (OSX)


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message