mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.
Date Mon, 01 Aug 2016 08:33:58 GMT


> On Aug. 1, 2016, 1:57 a.m., haosdent huang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 85-97
> > <https://reviews.apache.org/r/49828/diff/10/?file=1458774#file1458774line85>
> >
> >     Suppose we use `cgroups/cpu` as isolation first, then restart the agent with
`cgroups/cpu,cgroups/mem` in `isolation` flag. For those recovered containers, because they
don't appear in the memory subsystem before, they should return `Failure` here.

I think in memory subsystem (https://reviews.apache.org/r/49851/diff), you already return
`Failure` in `update()`/`usage()`, right?

And actually I think we do not need to care about the case that agent is restarted with a
different sets of isolators at this moment, because currently Mesos does not officially support
it yet. In future, we may support it with checkpointing what isolators (including their version)
have been used to launch the container, but for now, we do not need to worry about it.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49828/#review144282
-----------------------------------------------------------


On Aug. 1, 2016, 1:49 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49828/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2016, 1:49 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5039
>     https://issues.apache.org/jira/browse/MESOS-5039
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added default methods implementations for `Subsystem` base class.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 5f52a076a1fa3a21d886cb961ddeed5046a38d7c

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp a30ecafcbecc9d3b6eeea2b04dcb4d278750af41

> 
> Diff: https://reviews.apache.org/r/49828/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message