mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50123: Added GPU scheduler for docker containerizer.
Date Mon, 01 Aug 2016 06:07:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50123/#review144289
-----------------------------------------------------------




src/slave/containerizer/docker.hpp (lines 28 - 32)
<https://reviews.apache.org/r/50123/#comment210287>

    move this to the begining of this file



src/slave/containerizer/docker.cpp (line 66)
<https://reviews.apache.org/r/50123/#comment210288>

    Put `#include <set>` to the header of this file



src/slave/containerizer/docker.cpp (lines 1324 - 1333)
<https://reviews.apache.org/r/50123/#comment210311>

    ```
    // We block the launch executor process until the GPU
    // allocation finished. For docker containerizer, we must
    // wait for GPUs allocation completed, and pass allocated
    // GPUs to mesos-docker-executor.
    Future<set<Gpu>> allocate = allocator->allocate(requested);
    allocate.await();
    
    if (!allocate.isReady()) {
      return Failure("GPU allocator allocating GPU failed");
    }
    ```


- Guangya Liu


On 七月 29, 2016, 5:42 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50123/
> -----------------------------------------------------------
> 
> (Updated 七月 29, 2016, 5:42 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This added 'NvidiaGpuAllocator' to docker containerizer so that the
> docker containerizer can use it to allocate GPUs to the task with 'gpus'
> resource. Also, allocated GPUs will automatically deallocated after the
> job destroyed.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885 
>   src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 
>   src/tests/mesos.hpp 51c66f175c80ebacd5af230222ea7e4c81dfc1e8 
>   src/tests/mesos.cpp 30492d7e3b4c5e9ae9d2b2446cadba62d43a3c65 
> 
> Diff: https://reviews.apache.org/r/50123/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message