mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 50254: Added an example test for the V0/V1 Mesos java implementation.
Date Fri, 29 Jul 2016 17:26:19 GMT


> On July 26, 2016, 11:56 p.m., Vinod Kone wrote:
> > src/examples/java/V1TestFramework.java, line 134
> > <https://reviews.apache.org/r/50254/diff/1/?file=1448370#file1448370line134>
> >
> >     can you add a hearbeat timer and do a `reconnect()` if it fires?

I left a TODO to do this in a follow up patch.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50254/#review143645
-----------------------------------------------------------


On July 20, 2016, 7:03 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50254/
> -----------------------------------------------------------
> 
> (Updated July 20, 2016, 7:03 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
> 
> 
> Bugs: MESOS-5788
>     https://issues.apache.org/jira/browse/MESOS-5788
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an example test for the V0/V1 Mesos java implementation.
> 
> 
> Diffs
> -----
> 
>   configure.ac d2136909b7305498ae901a5ea00133142b77f9e6 
>   src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d 
>   src/examples/java/V1TestFramework.java PRE-CREATION 
>   src/examples/java/v1-test-framework.in PRE-CREATION 
>   src/tests/examples_tests.cpp ac513ce9aa3c8f366fe81ba937e3dc0d51a26940 
>   src/tests/java_v0_framework_test.sh PRE-CREATION 
>   src/tests/java_v1_framework_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50254/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message