mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 49616: Add suppression benchmark.
Date Thu, 28 Jul 2016 23:14:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/#review144029
-----------------------------------------------------------




src/tests/hierarchical_allocator_tests.cpp (line 3878)
<https://reviews.apache.org/r/49616/#comment209983>

    // Wait for all the `suppressOffers` operations to be processed.
    
    The above comments seems more clear than just saying `Settle clock...`



src/tests/hierarchical_allocator_tests.cpp (lines 3883 - 3887)
<https://reviews.apache.org/r/49616/#comment209985>

    What about the following, I think this is good enough and also other benchmark test are
using such format.
    
    ```
    // Advance the clock and trigger a batch allocation.
    Clock::advance(flags.allocation_interval);
    Clock::settle();
    ```


- Guangya Liu


On 七月 28, 2016, 8:42 p.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49616/
> -----------------------------------------------------------
> 
> (Updated 七月 28, 2016, 8:42 p.m.)
> 
> 
> Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5781
>     https://issues.apache.org/jira/browse/MESOS-5781
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Useful for high framework clusters which carry
>   many suppressed frameworks that are considered
>   during allocation.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp bb6947fcecb5b78047e98d10fc1278c612a69548

> 
> Diff: https://reviews.apache.org/r/49616/diff/
> 
> 
> Testing
> -------
> 
> MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK_Test.SuppressOffers*" make check
> 
> ...
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/12
> Using 5000 agents and 500 frameworks
> Added 500 frameworks in 9300us
> Added 5000 agents in 15.881391secs
> allocate() took 15.537025secs to make 5000 offers with 100 out of 500 frameworks suppressing
offers
> allocate() took 15.175028secs to make 5000 offers with 200 out of 500 frameworks suppressing
offers
> allocate() took 15.554843secs to make 5000 offers with 300 out of 500 frameworks suppressing
offers
> allocate() took 15.740833secs to make 5000 offers with 400 out of 500 frameworks suppressing
offers
> allocate() took 1.311314secs to make 0 offers with 500 out of 500 frameworks suppressing
offers
> [       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/12
(93269 ms)
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/13
> Using 5000 agents and 1000 frameworks
> Added 1000 frameworks in 17917us
> Added 5000 agents in 31.450037secs
> allocate() took 31.807624secs to make 5000 offers with 200 out of 1000 frameworks suppressing
offers
> allocate() took 32.039667secs to make 5000 offers with 400 out of 1000 frameworks suppressing
offers
> allocate() took 32.333716secs to make 5000 offers with 600 out of 1000 frameworks suppressing
offers
> allocate() took 32.938456secs to make 5000 offers with 800 out of 1000 frameworks suppressing
offers
> allocate() took 2.69174secs to make 0 offers with 1000 out of 1000 frameworks suppressing
offers
> [       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/13
(178827 ms)
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/14
> Using 5000 agents and 3000 frameworks
> Added 3000 frameworks in 55821us
> Added 5000 agents in 1.64208373333333mins
> allocate() took 1.63887131666667mins to make 5000 offers with 600 out of 3000 frameworks
suppressing offers
> allocate() took 1.66458908333333mins to make 5000 offers with 1200 out of 3000 frameworks
suppressing offers
> allocate() took 1.65244116666667mins to make 5000 offers with 1800 out of 3000 frameworks
suppressing offers
> allocate() took 1.71699065mins to make 5000 offers with 2400 out of 3000 frameworks suppressing
offers
> allocate() took 8.371823secs to make 0 offers with 3000 out of 3000 frameworks suppressing
offers
> [       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/14
(528494 ms)
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/15
> Using 5000 agents and 6000 frameworks
> Added 6000 frameworks in 110493us
> Added 5000 agents in 3.342676mins
> allocate() took 3.68091986666667mins to make 5000 offers with 1200 out of 6000 frameworks
suppressing offers
> allocate() took 3.67101323333333mins to make 5000 offers with 2400 out of 6000 frameworks
suppressing offers
> allocate() took 3.68049251666667mins to make 5000 offers with 3600 out of 6000 frameworks
suppressing offers
> allocate() took 3.71974983333333mins to make 5000 offers with 4800 out of 6000 frameworks
suppressing offers
> allocate() took 17.318823secs to make 0 offers with 6000 out of 6000 frameworks suppressing
offers
> ...
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message