mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 50374: Used `size_t` as the type of "size", "count" and "index".
Date Thu, 28 Jul 2016 22:54:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50374/#review144023
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On July 23, 2016, 9:54 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50374/
> -----------------------------------------------------------
> 
> (Updated July 23, 2016, 9:54 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We should use `size_t` as the type of "size", "count" and "index"
> variables in general, as it provides some additional information
> to the reader.
> 
> Some reference as following:
> 1) http://www.cplusplus.com/reference/cstring/size_t/
> 2) http://stackoverflow.com/questions/131803/unsigned-int-vs-size-t
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 769dfa242ed5322a72b65fbb422894e70af2ad0c

>   src/tests/containerizer/port_mapping_tests.cpp 3675c02453160417b24c8b3b0d001208504515a5

>   src/tests/hierarchical_allocator_tests.cpp bb6947fcecb5b78047e98d10fc1278c612a69548

> 
> Diff: https://reviews.apache.org/r/50374/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message