mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Review Request 50494: Change module parameters override to merge instead of replace.
Date Wed, 27 Jul 2016 11:49:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50494/
-----------------------------------------------------------

Review request for mesos and Joseph Wu.


Repository: mesos


Description
-------

If parameters are passed to ModuleManager::create, they are merged
with statically loaded ones. Runtime parameters take precedence over
static ones if key conflicts.


Diffs
-----

  src/module/manager.hpp 78aea44c07cf0304d3c41728cc733dcf8bb60b0c 
  src/tests/module_tests.cpp 6e003e56582b58b4a6c1d14105159e1190c36fb9 

Diff: https://reviews.apache.org/r/50494/diff/


Testing
-------

make check


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message