mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50123: Added GPU scheduler for docker containerizer.
Date Wed, 27 Jul 2016 08:51:47 GMT


> On July 27, 2016, 7:55 a.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 349
> > <https://reviews.apache.org/r/50123/diff/1/?file=1445669#file1445669line349>
> >
> >     Why do you add the comment here? This flag does not seems to related to gpu.

This should be merged to https://reviews.apache.org/r/50124 , we need to make every patch
as atomic as possible.


> On July 27, 2016, 7:55 a.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 1357
> > <https://reviews.apache.org/r/50123/diff/1/?file=1445669#file1445669line1357>
> >
> >     Seems no one is using `nvidiaGpus`? It should be set as parameter for `--device`
when running container.

I would suggest you create a new patch to handle `nvidiaGpus`, getting all of the logic for
handling `nvidiaGpus` in this patch and https://reviews.apache.org/r/50124/ to create a new
patch.

Also seems the name of `nvidiaGpuDevices` is better than `nvidiaGpus`.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50123/#review143692
-----------------------------------------------------------


On July 18, 2016, 9:17 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50123/
> -----------------------------------------------------------
> 
> (Updated July 18, 2016, 9:17 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This added 'NvidiaGpuAllocator' to docker containerizer so that the
> docker containerizer can use it to allocate GPUs to the task with 'gpus'
> resource. Also, allocated GPUs will automatically deallocated after the
> job destroyed.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885 
>   src/slave/containerizer/docker.cpp f1ecf3b25d85597f6c3dcaa47968860ed119dbd5 
> 
> Diff: https://reviews.apache.org/r/50123/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message