mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 50482: Fixed the CORS error when redirect in webui.
Date Wed, 27 Jul 2016 05:49:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50482/#review143677
-----------------------------------------------------------



LGTM and verified that the web UI issue was solved.


src/master/http.cpp (line 2038)
<https://reviews.apache.org/r/50482/#comment209544>

    Is `request.url.path == stringify(request.url)` guaranteed? Even if it is, would `request.url.path`
be more explicit?



src/webui/master/static/js/controllers.js (lines 375 - 376)
<https://reviews.apache.org/r/50482/#comment209545>

    Fix indentation.


- Jiang Yan Xu


On July 26, 2016, 8:41 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50482/
> -----------------------------------------------------------
> 
> (Updated July 26, 2016, 8:41 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5911
>     https://issues.apache.org/jira/browse/MESOS-5911
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the CORS error when redirect in webui.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 1cbec976ccedae81def388c62889624aaf9a794e 
>   src/webui/master/static/js/controllers.js ceaf1402ebdae4efd1a8a6fc9c7b795de69e2fc0

> 
> Diff: https://reviews.apache.org/r/50482/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message