mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 50254: Added an example test for the V0/V1 Mesos java implementation.
Date Tue, 26 Jul 2016 23:56:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50254/#review143645
-----------------------------------------------------------




src/Makefile.am (line 1535)
<https://reviews.apache.org/r/50254/#comment209484>

    whitespace.



src/Makefile.am (line 2235)
<https://reviews.apache.org/r/50254/#comment209485>

    whitespace.



src/examples/java/V1TestFramework.java (line 134)
<https://reviews.apache.org/r/50254/#comment209488>

    can you add a hearbeat timer and do a `reconnect()` if it fires?



src/examples/java/V1TestFramework.java (line 334)
<https://reviews.apache.org/r/50254/#comment209487>

    would be nice to include the version in the `name` as well.



src/examples/java/V1TestFramework.java (line 349)
<https://reviews.apache.org/r/50254/#comment209486>

    pass args[2] as well if it's supplied to configure number of tasks.


- Vinod Kone


On July 20, 2016, 7:03 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50254/
> -----------------------------------------------------------
> 
> (Updated July 20, 2016, 7:03 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
> 
> 
> Bugs: MESOS-5788
>     https://issues.apache.org/jira/browse/MESOS-5788
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an example test for the V0/V1 Mesos java implementation.
> 
> 
> Diffs
> -----
> 
>   configure.ac d2136909b7305498ae901a5ea00133142b77f9e6 
>   src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d 
>   src/examples/java/V1TestFramework.java PRE-CREATION 
>   src/examples/java/v1-test-framework.in PRE-CREATION 
>   src/tests/examples_tests.cpp ac513ce9aa3c8f366fe81ba937e3dc0d51a26940 
>   src/tests/java_v0_framework_test.sh PRE-CREATION 
>   src/tests/java_v1_framework_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50254/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message