mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 50362: Added an appropriate content type for the /help endpoints.
Date Fri, 22 Jul 2016 22:26:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50362/#review143291
-----------------------------------------------------------


Ship it!




Thanks for fixing it promply!

- Anand Mazumdar


On July 22, 2016, 10:24 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50362/
> -----------------------------------------------------------
> 
> (Updated July 22, 2016, 10:24 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Artem Harutyunyan.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `Content-Type` header was set to "text/plain" by default in all
> responses here: 
> https://reviews.apache.org/r/46725/
> 
> This had the adverse consequence of changing the `/help` endpoints
> into plain text.  Previously, the browser would see some `<html>`
> tags and assume the content was HTML.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/help.cpp 5bb1ddd8ae4c180972e91b4b4ac6d83d65c4a4b0 
> 
> Diff: https://reviews.apache.org/r/50362/diff/
> 
> 
> Testing
> -------
> 
> Started a master and hit `/help` and `/help/master`.  Confirmed that I did not get a
wall of javascript in plain text.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message