mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 48694: Optimized `UUID::fromString` and `UUID::toString` in stout.
Date Thu, 21 Jul 2016 16:17:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48694/
-----------------------------------------------------------

(Updated July 21, 2016, 4:17 p.m.)


Review request for mesos and Anand Mazumdar.


Changes
-------

Add clarifying comment.


Repository: mesos


Description
-------

Rather than using `std::istringstream` and `std::ostringstream`,
instead use the facilities provided by Boost's UUID for input
and output respectively. This improves a simple benchmark that
uses `fromString` and `toString` by ~7x.


Diffs (updated)
-----

  3rdparty/stout/include/stout/uuid.hpp a57896c78a35de677546ff7da116d669cfad1d66 

Diff: https://reviews.apache.org/r/48694/diff/


Testing
-------

make check

Benchmark is here: https://gist.github.com/anonymous/138d0333656871bddc2dfaa61fbf033e -- happy
to submit it as an RR as well (with cleanup), but I didn't think it was warranted.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message