mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 50208: Fixed a file descriptor leak bug while reading file.
Date Wed, 20 Jul 2016 02:35:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50208/#review142895
-----------------------------------------------------------


Ship it!




Ship It!

- haosdent huang


On July 20, 2016, 1:45 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50208/
> -----------------------------------------------------------
> 
> (Updated July 20, 2016, 1:45 a.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: mesos-5867
>     https://issues.apache.org/jira/browse/mesos-5867
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There are two early returns without closing the file
> when using read_file operator API. The two returns are:
> 
> - when `length=0`
> - when finishes reading file
> 
> 
> Diffs
> -----
> 
>   src/files/files.cpp 8ab8f8aad9cfe1e536b29e8994fcd8599627e590 
> 
> Diff: https://reviews.apache.org/r/50208/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message